fix: remove %pistol-extra% arguments when not passed to pistol #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it took long for me to notice it,
PR (#58) introduced a bug which would cause trouble when invoking
pistol
without extra arguments (and the config expected those).Basically, it would pass, for example,
%pistol-extra3%
, literally, instead of the argument (because it wasn't there), instead of just removing it from the arguments array.The solution, as can be read in the code, is to make the argument an empty string and then, when appending to the other arguments, check if it is empty before doing so.
Note that this is necessary if one is to put multiple %pistol-extra% as in #56 .